fix: use correct children indentation for logs.access.filters

traefik · Oct 16, 2024 · 59073ef · 59073ef
1 parent 016822d
commit 59073ef
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 18 deletions.
diff --git a/traefik/VALUES.md b/traefik/VALUES.md
@@ -131,11 +131,11 @@ Kubernetes: `>=1.22.0-0`
 | logs.access.fields.general.names | object | `{}` | Names of the fields to limit. |
 | logs.access.fields.headers | object | `{"defaultmode":"drop","names":{}}` | [Limit logged fields or headers](https://doc.traefik.io/traefik/observability/access-logs/#limiting-the-fieldsincluding-headers) |
 | logs.access.fields.headers.defaultmode | string | `"drop"` | Set default mode for fields.headers |
-| logs.access.filters | object | `{}` | Set [filtering](https://docs.traefik.io/observability/access-logs/#filtering) |
+| logs.access.filters | object | `{"minduration":"","retryattempts":false,"statuscodes":""}` | Set [filtering](https://docs.traefik.io/observability/access-logs/#filtering) |
+| logs.access.filters.minduration | string | `""` | Set minDuration, to keep access logs when requests take longer than the specified duration |
+| logs.access.filters.retryattempts | bool | `false` | Set retryAttempts, to keep the access logs when at least one retry has happened |
+| logs.access.filters.statuscodes | string | `""` | Set statusCodes, to limit the access logs to requests with a status codes in the specified range |
 | logs.access.format | string | `nil` | Set [access log format](https://doc.traefik.io/traefik/observability/access-logs/#format) |
-| logs.access.minduration | string | `""` |  |
-| logs.access.retryattempts | bool | `false` |  |
-| logs.access.statuscodes | string | `""` |  |
 | logs.general.filePath | string | `""` | To write the logs into a log file, use the filePath option. |
 | logs.general.format | string | `nil` | Set [logs format](https://doc.traefik.io/traefik/observability/logs/#format) |
 | logs.general.level | string | `"INFO"` | Alternative logging levels are TRACE, DEBUG, INFO, WARN, ERROR, FATAL, and PANIC. |

diff --git a/traefik/values.schema.json b/traefik/values.schema.json
@@ -545,7 +545,18 @@
                             "type": "object"
                         },
                         "filters": {
-                            "properties": {},
+                            "additionalProperties": false,
+                            "properties": {
+                                "minduration": {
+                                    "type": "string"
+                                },
+                                "retryattempts": {
+                                    "type": "boolean"
+                                },
+                                "statuscodes": {
+                                    "type": "string"
+                                }
+                            },
                             "type": "object"
                         },
                         "format": {
@@ -559,15 +570,6 @@
                                 "string",
                                 "null"
                             ]
-                        },
-                        "minduration": {
-                            "type": "string"
-                        },
-                        "retryattempts": {
-                            "type": "boolean"
-                        },
-                        "statuscodes": {
-                            "type": "string"
                         }
                     },
                     "type": "object"

diff --git a/traefik/values.yaml b/traefik/values.yaml
@@ -352,10 +352,13 @@ logs:
     # -- Set [bufferingSize](https://doc.traefik.io/traefik/observability/access-logs/#bufferingsize)
     bufferingSize:  # @schema type:[integer, null]
     # -- Set [filtering](https://docs.traefik.io/observability/access-logs/#filtering)
-    filters: {}
-    statuscodes: ""
-    retryattempts: false
-    minduration: ""
+    filters:  # @schema additionalProperties: false
+      # -- Set statusCodes, to limit the access logs to requests with a status codes in the specified range
+      statuscodes: ""
+      # -- Set retryAttempts, to keep the access logs when at least one retry has happened
+      retryattempts: false
+      # -- Set minDuration, to keep access logs when requests take longer than the specified duration
+      minduration: ""
     # -- Enables accessLogs for internal resources. Default: false.
     addInternals: false
     fields: