Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): 🔧 fix typo on tracing test #900

Merged
merged 1 commit into from
Aug 1, 2023
Merged

chore(tests): 🔧 fix typo on tracing test #900

merged 1 commit into from
Aug 1, 2023

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Aug 1, 2023

What does this PR do?

Fix a test on openTelemetry for Traefik v3

Motivation

The test is incorrect. Recreated from #896 since it was closed.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit cbb17ff into traefik:master Aug 1, 2023
1 check passed
@mloiseleur mloiseleur deleted the fix/tracing_test branch September 14, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants