Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect correctly v3 version when using sha in image.tag #909

Merged
merged 10 commits into from
Aug 16, 2023
Merged

fix: detect correctly v3 version when using sha in image.tag #909

merged 10 commits into from
Aug 16, 2023

Conversation

davhdavh
Copy link
Contributor

Fix #908

@ldez ldez changed the title Fix semverCompare does not work with sha Fix semverCompare to work with sha Aug 13, 2023
@ldez ldez marked this pull request as draft August 13, 2023 05:10
@ldez
Copy link
Contributor

ldez commented Aug 13, 2023

Hello,

maybe you can run make test locally?

@ldez
Copy link
Contributor

ldez commented Aug 13, 2023

Each commit sent a notification.
Please can you run make test locally?

@davhdavh
Copy link
Contributor Author

I use the online editor :)

@ldez
Copy link
Contributor

ldez commented Aug 13, 2023 •
edited
Loading

So can you clone and run the project locally?
Or just create another branch and enable GitHub action on your fork?

@davhdavh davhdavh marked this pull request as ready for review August 13, 2023 05:19
@davhdavh
Copy link
Contributor Author

that would have been the smart thing to do, but I was not expecting the syntax to fight me so much

mloiseleur
mloiseleur approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davhdavh.
It's clearly written and well tested !

@mloiseleur mloiseleur added the kind/enhancement New feature or request label Aug 16, 2023
@mloiseleur mloiseleur changed the title Fix semverCompare to work with sha fix: detect correctly v3 version when using sha in image.tag Aug 16, 2023
@traefiker traefiker merged commit 1f043da into traefik:master Aug 16, 2023
1 check passed
@davhdavh davhdavh deleted the fix-semver branch August 16, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error calling semverCompare: Invalid Semantic Version
4 participants
@davhdavh @ldez @mloiseleur @traefiker