Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove label whitespace at TLSOption #933

Merged
merged 1 commit into from
Oct 13, 2023
Merged

chore: remove label whitespace at TLSOption #933

merged 1 commit into from
Oct 13, 2023

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Oct 12, 2023

What does this PR do?

There is some whitespace next to the labels section inside the Helm chart.

This PR just removes these spaces

More

  • Yes, I updated the tests accordingly -> not required
  • Yes, I ran make test and all the tests passed

@fty4
chore: remove label whitespace at TLSOption
95b553f 
There is some whitespace next to the labels section inside the Helm chart.
mloiseleur
mloiseleur approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, we missed those ones.
Thanks @fty4.

@traefiker traefiker merged commit 6f8d874 into traefik:master Oct 13, 2023
1 check passed
@fty4 fty4 deleted the chore/rm-tlsoption-whitespace branch October 18, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

Assignees
No one assigned
Labels
kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fty4 @mloiseleur @traefiker