fix: add Prometheus scraping annotations only if serviceMonitor not created #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
changed the title
mloiseleur
approved these changes
Oct 17, 2023
|
Thanks for this PR @SebPlv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are two ways to enable Prometheus scraping :
This PR intend to add Prometheus scraping Annotations only if 'metrics.prometheus' exists but 'metrics.prometheus.serviceMonitor' does not..
Motivation
Adding scraping annotations and ServiceMonitor (or podMonitor) for the same pod can result to get metrics being collected twice by Prometheus.
More
make testand all the tests passed