-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to optionally show "Total" in most dashboard entry types #89
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 92.57% 92.62% +0.05%
==========================================
Files 70 70
Lines 1549 1533 -16
==========================================
- Hits 1434 1420 -14
+ Misses 80 79 -1
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine @jmattheis @simhnna
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤏😏
Having this as an option would be great for my use case, as I'm currently using Traggo to track billable hours on consulting projects. I often wonder the total time logged for the day against different projects, and I pretty much never have more than one entry going at the same time. |
Hi guys, what is the status of this PR? I would like this feature too |
I would love having this feature released |
+1 I look at my Traggo dashboard 10x a day with daily, weekly and monthly hours broken down by client, and I'd love to have the total automatically computed for me, rather than doing it in my head 😄 |
Is this waiting on anything? I pulled the code and everything looks good. |
@hulmgulm Do you perhaps push this to a docker registry for use? |
This feature is ready to be merged for a long time now and many people are asking for it. I don't want to create a fork of Traggo. @jmattheis @simhnna, what do I need to do get this PR merged? |
@hulmgulm Yeah, you're right. I'll try to review the PR this week and then create a release for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I've made some small changes (see fixups)
- add default:false for total sql field
- refactor the summing of the time spans to use reduce
- move the getTotalTitle method
Vielen Dank Jannis! |
@jmattheis congrats, took years but finally 👏 |
This is my first attempt to implement #88
The Dashboard Entry Editor allows to choose Total Hidden/Visible for all table types:
Sample dashboard: