Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comma bug in wg config, Dockerfile dependencies, added 'update' to Makefile #14153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samsipe
Copy link

@samsipe samsipe commented Feb 17, 2021

Description

This is three quick fixes I figured I would share with the community.

  1. The wireguard config generator had a comma error, fixed @ roles/wireguard/defaults/main.yml
  2. Docker Image wouldn't build on any OS (added cargo dependency and it builds on MacOs and Ubuntu) @ Dockerfile
  3. Added a quick and easy Make Command for updating users in accordance with the documentation @ Makefile
    • I also changed the Makefile to work on any OS using $$(pwd) format.

Motivation and Context

Couldn't find any open issues on this but this fixes the issues above. This makes it easier for those deploying Algo from Docker, especially if they want to build their own docker image.

How Has This Been Tested?

Deployed a VPN to AWS and Linode using these changes from GitLab CI/CD, Ubuntu, and MacOS.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) (Not necessary)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation. (Not necessary)
  • I have updated the documentation accordingly. (Not necessary)
  • I have added tests to cover my changes. (Not necessary)
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2021

CLA assistant check
All committers have signed the CLA.

@samsipe
Copy link
Author

samsipe commented Feb 18, 2021

It looks like all of the lint check annotations were from unchanged files... not sure why Github just caught them now.

@davidemyers davidemyers mentioned this pull request Mar 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants