[CIR] Fixed ClangIR linker #76
Open
+277
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frabert
reviewed
Sep 30, 2025
wizardengineer
commented
Oct 6, 2025
wizardengineer
force-pushed
the
julius/more-cir-fixes
branch
4 times, most recently
from
4a417cf to
6289d4f
Compare
wizardengineer
commented
Oct 7, 2025
| } | ||
|
|
||
| // CIR: cir.global "private" internal dso_local addrspace(offload_local) @_ZZ2fnvE1j : !s32i | ||
| // CIR: cir.global "private" internal dso_local addrspace(<offload_local>) @_ZZ2fnvE1j : !s32i |
There was a problem hiding this comment.
Had to include changes to for tests
|
I see two CI tests failing, i'll make sure to get to them |
wizardengineer
force-pushed
the
julius/fix-cir-linker
branch
from
0b65191 to
c270f7b
Compare
|
All the CI tests should pass now :) |
wizardengineer
force-pushed
the
julius/fix-cir-linker
branch
3 times, most recently
from
87102ae to
a076172
Compare
wizardengineer
commented
Oct 8, 2025
|
After making sure we've addressed all points, I would suggest cleaning up the git history before the final merge |
wizardengineer
force-pushed
the
julius/fix-cir-linker
branch
from
c141d46 to
3e378f5
Compare
[CIR][Linker] Fixed string collision [CIR][Linker] WIP attempted to resolve global conflict issue [CIR][Linker] Fixed issue with conflicting symbols, in final linking [CIR][Linker] Fixed test that got affected from changes [CIR][Linker] Clean-up, remove unneeded
[CIR] Clean up CIRLinkerInterface [CIR] Remove stray include
wizardengineer
force-pushed
the
julius/fix-cir-linker
branch
from
3e378f5 to
8d9f057
Compare
frabert
approved these changes
Oct 14, 2025
Jezurko
reviewed
Oct 15, 2025
Comment on lines
974
to
+975
| let assemblyFormat = [{ | ||
| `` custom<AddressSpaceValue>($value) | ||
| `<` custom<AddressSpaceValue>($value) `>` |
There was a problem hiding this comment.
Just curious, is this a regression in upstream, or are we doing something differently that requires this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.