Skip to content

Conversation

@seathegood
Copy link

Problem: Navigations sometimes stalled; only 1–2 pages captured; inconsistent “Go to Page” functionality; inline arrow functions inside loops tripped no-loop-func in lint.

Changes:

  • Added robust reader UI handling (settings/TOC/menu fallbacks).
  • LOCATION_MODE for location-only footers.
  • Safer page-advance (advanceOnePageFromStuck) with keyboard/click fallbacks.
  • Replaced inline ...catch(() => …) lambdas inside loops with try/catch.
  • Minor lint cleanups (numeric separators, naming, ternary → ??, remove unused var in transcriber).
  • Test plan:
    -- Book A (the one that previously exported ~449 pages): full capture succeeded; last footer lines stable.
    -- Book B (“Five Stars”): previously captured 2 pages; now advances reliably (include brief before/after notes and the new pages count).
  • Risk/Regression: Low; changes are guarded with timeouts, fallbacks, and conservative LOCATION_MODE.
    -- Screenshots/Artifacts: link to relevant run.log snippets and a couple of output image paths.

…tent

- Add strict filename parsing and deterministic sort for screenshots
- Implement exponential backoff for OCR refusals, 429s, and 5xx errors
- Lower default concurrency to reduce rate limit drops
- Log missing pages to highlight gaps in output
- Print summary instead of dumping full JSON to stdout
…st practices.

 - Centralized timeouts & selectors.
 - Reader helpers
 - Safer cleanup
 - Consistent selectors
 - Minor hygiene
@socket-security
Copy link

socket-security bot commented Sep 26, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedkindle-api-ky@​1.0.1681009979100
Added@​fisch0920/​eslint-config@​1.4.0821007977100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant