rewrite to esm and upgrade packages

[mifi]

note: we cannot upgrade got beyond 13 (14) because it requires node20.

see also https://github.com/transloadit/api2/pull/6341

Note: Breaking changes:

• gotRetry option no longer accepts number. Instead use { limit: 0 }. See got retry object documentation.
• Requires Node.js v20 or newer

[kvz]

Looking good! Just a few nits , and the node 18 question.

im not feeling strongly, but it seemed there weren’t very big reasons for dropping it outside a got upgrade, which you didn’t end up doing?

Edit: Disregard the node 18 comment, I hadn’t seen the last slack messages yet. We can drop it, as you do here 👌

Curious if you figured out why the missing error in the assembly status schema was not a problem, did no code check for it?

[mifi]

Curious if you figured out why the missing error in the assembly status schema was not a problem, did no code check for it?

correct. no code checked for it. it was the case of GETting an assembly and checking the error property on that response.
in other cases where there is an error during assembly execution, we throw an error (like when creating an assembly), but we didn't have any code that actually GETs a failed assembly after it has failed. but i've added it here now.

[kvz]

Awesome, thanks!!

[kvz]

Let’s add tsx, if you agree, and then we can merge