@uppy/angular: declare components as standalone & support 20.x #5843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc191aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
qxprakash
added
the
safe to test
Diff output filesNo diff |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Murderlon
approved these changes
Jul 28, 2025
Murderlon
changed the title
Murderlon
changed the title
|
when will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5759
Closes #5833.
This PR:
The @uppy/angular package underwent major updates in v0.80 (27492bc), where we dropped support for NgModules in favor of standalone components. This change aligns with the direction set by the Angular team — starting from Angular v17, and becoming default in v19, all components are standalone by default. This is now the recommended way to build UI components in Angular.
However, the docs and examples have not yet been updated to reflect this. That will be addressed in #5818.
Even though components are standalone by default starting from Angular 17+, it is still considered good practice to explicitly declare them as standalone. This is also validated by the Angular LSP, which raises an error when this declaration is missing.
Changes in this PR: