Add support for Static CT API entry bundle paths#178
Merged
AlCutter merged 9 commits intotransparency-dev:mainfrom Aug 29, 2024
Merged
Add support for Static CT API entry bundle paths#178AlCutter merged 9 commits intotransparency-dev:mainfrom
AlCutter merged 9 commits intotransparency-dev:mainfrom
Conversation
mhutchinson
reviewed
Aug 28, 2024
AlCutter
force-pushed
the
ct_data_paths
branch
from
4e86c0e to
ce7582b
Compare
phbnf
reviewed
Aug 29, 2024
phbnf
approved these changes
Aug 29, 2024
mhutchinson
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to Tessera for storing CT entry bundles in under
data.The Static CT API defines leaf entry bundles as being stored under a
tiles/datapath. This is incompatible with the tlog-tiles spec which defines that path astiles/entries.This PR adds a CT-only storage option,
WithCTLayout, which instructs storage implementations to use the Static CT API path.A strong goal of this PR was to make it impossible for users of Tessera to implement arbitrary layout schemes, or accidentally use the CT layout without a clear signal that this is what they are doing.
Fixes #171