-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in README.md #147
Fix broken link in README.md #147
Conversation
Fixes broken link to the [CT-Tiles] api spec document that was renamed.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
README.md
Outdated
@@ -27,7 +27,7 @@ Tessera goals: | |||
* Broadly similar write-throughput and write-availability, and potentially _far_ higher read-throughput | |||
and read-availability compared to Trillian v1 (dependent on underlying infrastructure) | |||
* Enable building of arbitrary log personalities, including support for the peculiarities of a | |||
[CT Tiles](https://github.com/C2SP/C2SP/blob/main/sunlight.md) compliant log. | |||
[CT Tiles](https://github.com/C2SP/C2SP/blob/main/static-ct-api.md) compliant log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CT Tiles](https://github.com/C2SP/C2SP/blob/main/static-ct-api.md) compliant log. | |
[Static CT API](https://c2sp.org/static-ct-api) compliant log. |
The c2sp.org urls are canonical, we should probably use those. (In the future, they may render the specs directly instead of just redirecting to Github)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Rename [CT-Tiles] to [Static CT API] as it appears in the document.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 35.80% 35.94% +0.13%
==========================================
Files 16 33 +17
Lines 1363 2824 +1461
==========================================
+ Hits 488 1015 +527
- Misses 801 1698 +897
- Partials 74 111 +37 ☔ View full report in Codecov by Sentry. |
Fixes broken link to the [CT-Tiles] api spec document that was renamed.