Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache locally whether issuers have been persisted or not already. #169

Merged
merged 15 commits into from
Aug 23, 2024

Conversation

phbnf
Copy link
Contributor

@phbnf phbnf commented Aug 22, 2024

This saves a few round trips to the IssuerStorage.

Towards #88

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 34.22%. Comparing base (46ec9c2) to head (d0e4643).
Report is 83 commits behind head on main.

Files Patch % Lines
personalities/sctfe/storage.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   35.80%   34.22%   -1.58%     
==========================================
  Files          16       34      +18     
  Lines        1363     2992    +1629     
==========================================
+ Hits          488     1024     +536     
- Misses        801     1857    +1056     
- Partials       74      111      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

personalities/sctfe/storage.go Outdated Show resolved Hide resolved
personalities/sctfe/storage.go Outdated Show resolved Hide resolved
personalities/sctfe/storage.go Outdated Show resolved Hide resolved
personalities/sctfe/storage.go Outdated Show resolved Hide resolved
@phbnf phbnf merged commit 68ce423 into transparency-dev:main Aug 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants