Remove default options from ResolveStorageOptions #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutchinson
reviewed
Aug 28, 2024
| BatchMaxAge: defaultQueueMaxAge, | ||
| BatchMaxSize: defaultBatchMaxSize, | ||
| }, opts...) | ||
| opt := tessera.ResolveStorageOptions(opts...) |
There was a problem hiding this comment.
This changes the behaviour of mysql to switch to a batch size of 1 instead of 256?
There was a problem hiding this comment.
It does, but that brings it into line with the others, and I've just changed the "line" to 256 within 250ms.
We can revisit in the future.
There was a problem hiding this comment.
The defaultBatchMaxSize and defaultQueueMaxAge consts in this file can be removed.
mhutchinson
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the default options param from
ResolveStorageOptions.This is an unnecessary source of complexity at the moment.