Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support file:// scheme in integration test #218

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Support file:// scheme in integration test #218

merged 2 commits into from
Sep 5, 2024

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Sep 5, 2024 •
edited
Loading

#8 #22

The files created by Docker are always owned by root. The integration test cannot read the checkpoints, tiles and entry bundles.

@roger2hk
Copy link
Contributor Author

roger2hk commented Sep 5, 2024 

=== RUN   TestLiveLogIntegration
    integration_test.go:105: client.FetchCheckpoint: open /tmp/tessera-posix-log/checkpoint: permission denied
    integration_test.go:108: checkpoint not found
--- FAIL: TestLiveLogIntegration (0.00s)

@AlCutter
Copy link
Collaborator

AlCutter commented Sep 5, 2024

#221 Should fix the perms issue, sorry about that.

@roger2hk roger2hk force-pushed the integration-test-add-file-scheme branch from 3bde9ce to fed52d7 Compare September 5, 2024 17:12
@roger2hk
Copy link
Contributor Author

roger2hk commented Sep 5, 2024

#221 Should fix the perms issue, sorry about that.

It works after the rebase. Thanks!

@roger2hk roger2hk marked this pull request as ready for review September 5, 2024 17:24
@roger2hk roger2hk force-pushed the integration-test-add-file-scheme branch from fed52d7 to 1d8a533 Compare September 5, 2024 17:29
@roger2hk roger2hk merged commit 3a7b97c into transparency-dev:main Sep 5, 2024
12 checks passed
@roger2hk roger2hk deleted the integration-test-add-file-scheme branch September 5, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@mhutchinson mhutchinson Awaiting requested review from mhutchinson

Assignees

@mhutchinson mhutchinson

@AlCutter AlCutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roger2hk @AlCutter @mhutchinson