Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration to select desired output type of boolean #116

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

trung-huynh
Copy link
Contributor

Context: PR will solve the issue here: #109, it is through solution for an ad-hoc change: #110

@trung-huynh trung-huynh requested a review from a team as a code owner January 5, 2022 08:44
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of comments.

Will it be released as 0.8.1?

README.md Outdated Show resolved Hide resolved
src/main/java/org/embulk/output/td/TdOutputPlugin.java Outdated Show resolved Hide resolved
@trung-huynh
Copy link
Contributor Author

@dmikurube ,

Will it be released as 0.8.1?

Yes, as 0.8.0 was released: https://rubygems.org/gems/embulk-output-td/versions/0.8.0-java.

@dmikurube dmikurube added this to the v0.8.1 milestone Jan 11, 2022
build.gradle Outdated Show resolved Hide resolved
@dmikurube
Copy link
Member

Thanks for addressing the comments. Merging, and releasing v0.8.1.

@dmikurube dmikurube merged commit 9cb5500 into master Jan 14, 2022
@dmikurube dmikurube deleted the option-to-write-boolean branch January 14, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants