Rename supertype identifiers

[314eter]

This solves the problem mentioned in #290. Supertypes with similar names to other nodes (e.g. _sequence_expression and sequence_expression) result in the same identifier (SequenceExpression).

I solved this by prefixing names that start with _ with Super. These are always supertypes, since other names starting with an underscore are invisible in the AST.

Some examples of the new behaviour:

toHaskellCamelCaseIdentifier "expression" = "expression"
toHaskellCamelCaseIdentifier "sequence_expression" = "sequenceExpression"
toHaskellCamelCaseIdentifier "_sequence_expression" = "superSequenceExpression"
toHaskellCamelCaseIdentifier "__sequence_expression" = "superSuperSequenceExpression"
toHaskellCamelCaseIdentifier "__sequence__expression" = "superSuperSequenceUnderscoreExpression"

toHaskellPascalCaseIdentifier "expression" = "Expression"
toHaskellPascalCaseIdentifier "sequence_expression" = "SequenceExpression"
toHaskellPascalCaseIdentifier "_sequence_expression" = "SuperSequenceExpression"
toHaskellPascalCaseIdentifier "__sequence_expression" = "SuperSuperSequenceExpression"
toHaskellPascalCaseIdentifier "__sequence__expression" = "SuperSuperSequenceUnderscoreExpression"

[XVilka]

Almost two years have passed. Was there any decision on this yet? cc @robrix

[robrix]

@XVilka apologies, this did indeed slip through the cracks. I'd like to see better names for the inner functions (I only use go when there's only the one such, and even then it is probably a bad habit).

Are you running into the problem this resolves? Can you confirm that this PR fixes it for you?

[robrix]

Whoops, didn't mean to close this.

[robrix]

🤣

[314eter]

I opened this this PR to fix a problem I encountered in github/semantic#623. It's still needed to get OCaml support in semantic (and probably for some other languages too). But since this was apparently not the way to get code navigation support in Github, I never finished it.

[robrix]

@314eter @XVilka Given that, any objection to me closing this out?

[XVilka]

@robrix no objections from my side, quite sad it's not used anywhere now though...