fix: Fix nested packages #470
Merged
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** packages are treated to be top-level only, so the nested ones aren't parsed correctly. **Solution** This moves packages into definition so they can be nested.
ckipp01
reviewed
Jun 8, 2025
| test-rust: true | ||
| test-node: true | ||
| test-python: true | ||
| test-go: true | ||
| test-swift: true | ||
| test-swift: false |
There was a problem hiding this comment.
Out of curiosity is there a reason we don't want to test swift anymore?
There was a problem hiding this comment.
The GitHub Action setup-swift is broken, so the CI currently fails on test-swift: https://github.com/tree-sitter/tree-sitter-scala/actions/runs/15515697083/job/43682548623
Run swift-actions/setup-swift@v2
/usr/bin/gpg --import /home/runner/work/_temp/f422a293-ac58-4b0d-b0e4-d1579ed0a03d
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
Error: Unexpected error, unable to continue. Please report at https://github.com/swift-actions/setup-swift/issues
The process '/usr/bin/gpg' failed with exit code 2
Stacktrace:
Error: The process '/usr/bin/gpg' failed with exit code 2
at ExecState._setResult (/home/runner/work/_actions/swift-actions/setup-swift/v2/dist/index.js:3197:25)
ckipp01
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
Problem
packages are treated to be top-level only,
so the nested ones aren't parsed correctly.
Solution
This moves packages into definition so they can be nested.