Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTifacts #87

Draft
wants to merge 8 commits into
base: mainline
Choose a base branch
from
Draft

ARTifacts #87

wants to merge 8 commits into from

Conversation

hunnybear
Copy link
Contributor

No description provided.

@hunnybear hunnybear changed the title Ar tifacts ARTifacts Sep 6, 2020
@hunnybear hunnybear marked this pull request as draft September 6, 2020 15:50
artifact=textures-latest
list_asset_url=https://api.github.com/repos/tribesthatmaybe/art_source/actions/artifacts
asset_url=$(curl "${list_asset_url}" | jq ".artifacts[] | select(.name==\"${artifact}\") | .url" | sed 's/\"//g')/zip
wget -O textures-latest.zip $asset_url/zip?access_token=${GITHUB_TOKEN}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try using ART_PAT but remember to declare it in the env section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pulls down the latest art assets right? we should figure out how to pin it
also been thinking about #85

Copy link
Contributor Author

@hunnybear hunnybear Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's just textures for the time being. Thinking nightly/rolling builds pull latest and tag builds pull that tag from art-source (don't have anything tagged yet, should probably start prerelease tagging at this point), thought just having the tag to use as a variable somewhere works for me just fine.

Also thanks for the declaration reminder :D

@hunnybear
Copy link
Contributor Author

crap, @otakup0pe looks like I didn't have the correct grant. for some reason my little rinkadink test let this work with read on repo.

{
"message": "You must have the actions scope to download artifacts.",
"documentation_url": "https://docs.github.com/rest/reference/actions#download-an-artifact"
}

@hunnybear
Copy link
Contributor Author

hunnybear commented Sep 7, 2020

so, somehow I got this thing working here: https://github.com/tribesthatmaybe/artifact_fetch_test/runs/1079679548, giving the PAT only read public. Could it have to do with the user which is associated with the PAT not having some access, best I could tell is the error I got seems to be related to some sort of API scope which is per-user, but I'm not terribly confident in my analysis

@hunnybear
Copy link
Contributor Author

showing off my inexperience with github workflows: am I guessing right that you created a github app for this, and not just a PAT for your account? didn't realize that was a thing until now, and in that case I gave you the wrong needed permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants