Skip to content

Conversation

bbktrifork
Copy link
Member

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds version fields to DispensingCard, DispensingPeriod, and PackingGroup entities in the XML schema definitions. This appears to be implementing versioning support for these core entities in what looks like a pharmaceutical or medical system.

  • Added version types and identifier-and-version composite types for all three entities
  • Updated request/response schemas to include version information
  • Modified existing entity definitions to incorporate version fields

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
PackingGroupVersion.xsd New schema defining version type for packing groups
PackingGroupIdentifierAndVersion.xsd New composite type combining identifier and version for packing groups
DispensingPeriodVersion.xsd New schema defining version type for dispensing periods
DispensingPeriodIdentifierAndVersion.xsd New composite type combining identifier and version for dispensing periods
DispensingCardVersion.xsd New schema defining version type for dispensing cards
DispensingCardIdentifierAndVersion.xsd New composite type combining identifier and version for dispensing cards
Multiple request/response XSD files Updated to include version fields and use new composite types
Multiple entity XSD files Updated to include version fields in their definitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<include schemaLocation="DispensingPeriodVersion.xsd"/>
<include schemaLocation="ModificationMetadata.xsd"/>
<include schemaLocation="DiscardedByDateTime.xsd"/>
<include schemaLocation="DiscardReason.xsd"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mangler at indsætte i body

</annotation>
<sequence>
<element name="Identifier" type="mc160:PackingGroupIdentifierType"/>
<element name="Version" type="mc160:PackingGroupVersionType"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forkert indentation?

<element name="ReportedBy" type="mc160:ModificatorType" minOccurs="0"/>
<element name="DrugMedication" type="mc160:DrugMedicationIdentifierAndVersionType"/>
<element name="DispensingCardIdentifier" type="mc160:DispensingCardIdentifierType" minOccurs="0"/>
<element name="DispensingCardVersion" type="mc160:DispensingCardVersionType" minOccurs="0"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan vi mon det? Hvad hvis de opdatere kortet imellem 2 versioner af PA, hvilken skal så på her?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants