-
Notifications
You must be signed in to change notification settings - Fork 2
Tilføjet Version til DispensingCard, DispensingPeriod og Packinggroup #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds version fields to DispensingCard, DispensingPeriod, and PackingGroup entities in the XML schema definitions. This appears to be implementing versioning support for these core entities in what looks like a pharmaceutical or medical system.
- Added version types and identifier-and-version composite types for all three entities
- Updated request/response schemas to include version information
- Modified existing entity definitions to incorporate version fields
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
PackingGroupVersion.xsd | New schema defining version type for packing groups |
PackingGroupIdentifierAndVersion.xsd | New composite type combining identifier and version for packing groups |
DispensingPeriodVersion.xsd | New schema defining version type for dispensing periods |
DispensingPeriodIdentifierAndVersion.xsd | New composite type combining identifier and version for dispensing periods |
DispensingCardVersion.xsd | New schema defining version type for dispensing cards |
DispensingCardIdentifierAndVersion.xsd | New composite type combining identifier and version for dispensing cards |
Multiple request/response XSD files | Updated to include version fields and use new composite types |
Multiple entity XSD files | Updated to include version fields in their definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
<include schemaLocation="DispensingPeriodVersion.xsd"/> | ||
<include schemaLocation="ModificationMetadata.xsd"/> | ||
<include schemaLocation="DiscardedByDateTime.xsd"/> | ||
<include schemaLocation="DiscardReason.xsd"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mangler at indsætte i body
</annotation> | ||
<sequence> | ||
<element name="Identifier" type="mc160:PackingGroupIdentifierType"/> | ||
<element name="Version" type="mc160:PackingGroupVersionType"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forkert indentation?
<element name="ReportedBy" type="mc160:ModificatorType" minOccurs="0"/> | ||
<element name="DrugMedication" type="mc160:DrugMedicationIdentifierAndVersionType"/> | ||
<element name="DispensingCardIdentifier" type="mc160:DispensingCardIdentifierType" minOccurs="0"/> | ||
<element name="DispensingCardVersion" type="mc160:DispensingCardVersionType" minOccurs="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan vi mon det? Hvad hvis de opdatere kortet imellem 2 versioner af PA, hvilken skal så på her?
No description provided.