Add tasks to drop and create test database #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `CONTRIBUTING.md` it says > To shorten the development loop you can: > > a) run trilogy tests locally with: make test > b) run ruby binding tests with cd contrib/ruby, bundle exec rake test. It's possible to run a test single example by passing a TESTOPTS environment variable like so: TESTOPTS=-n/test_packet_size_greater_than_trilogy_max_packet_len/. When you follow these instructions, it will fail if you do not have a `test` database created. This change adds tasks the following tasks: - `db:create` - `db:drop` - `db:clean` When running the ruby binding tests, it will run the `db:clean` task to drop the test database first (if it exists) and creates it. I think it will also be helpful to have a similar task in the `Makefile` so that `make test` can setup the DB if the user chooses not to use the docker approach. However, I am not sure how to do this 🤔 It might also be useful to push forward with trilogy-libraries#170 as we can pontentially move away from Docker for the CI builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
CONTRIBUTING.mdit saysWhen you follow these instructions, it will fail if you do not have a
testdatabase created. This change adds tasks the following tasks:db:createdb:dropdb:cleanWhen running the ruby binding tests, it will run the
db:cleantask to drop the test database first (if it exists) and creates it.I think it will also be helpful to have a similar task in the
Makefileso thatmake testcan setup the DB if the user chooses not to use the docker approach. However, I am not sure how to do this 🤔It might also be useful to push forward with
#170 as we can pontentially move away from Docker for the CI builds.