Skip to content

Conversation

@mosabua
Copy link
Member

@mosabua mosabua commented Oct 16, 2024

Description

To enable better understanding of how to write routing rules.

Update from @andythsu s PR for pending status .. once I saw the file I just updated it all instead of just a small section.

Note for reviewers - this is all just grammar and wrapping and similar changes. Nothing fundamentally changed in terms of content and technical information.

Additional context and related issues

#360

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 16, 2024
@mosabua mosabua force-pushed the pending branch 2 times, most recently from 203faf7 to 3784f19 Compare October 17, 2024 19:43
To enable better understanding of how to write routing rules.

Co-authored-by: Will Morrison <[email protected]>
Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mosabua mosabua merged commit ef336a6 into trinodb:main Oct 18, 2024
1 check passed
@github-actions github-actions bot added this to the 12 milestone Oct 18, 2024
@mosabua mosabua deleted the pending branch October 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants