Fix parsing failure on WITH clauses

[Chaho12]

Description

Fix parsing failure on WITH clauses.

Additional context and related issues

• close Parsing fails when there isn't default schema #528

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Fix parsing failures on WITH clauses. ({issue}`528`)

[mosabua]

The changes look ok but overall I think we are doing the wrong thing here .. we really should not try to parse the query since we are missing the full context .. only the coordinator really has that. I think in the long run we have to go down the route of farming this work out to a coordinator .. otherwise we end up pulling everything in and duplicating it so we kinda end up with the whole parsing code again.

[ebyhr]

Please add a test.

[Chaho12]

we really should not try to parse the query since we are missing the full context .. only the coordinator really has that.

I agree, even if it is quite helpful information. We should talk more on this next time.

[willmostly]

it looks like we are preserving with clause names in the tables list - I think we should exclude them. Lets discuss if needed

[willmostly]

If you revert this to handle Query nodes, then we can bypass my concern about encountering a Table with a WithQuery name before it is added to temporaryTables. The concern is basically that node.getChildren() could return a list with the QueryBody before the With. If we explicitly process any With, then we can ensure that the names are collected before they are referenced. Something like

case Query query -> query.getWith().ifPresent(
                    with -> temporaryTables.addAll(with.getQueries().stream().map(WithQuery::getName).map(Identifier::getValue).map(QualifiedName::of).toList()));

[Chaho12]

bypass my concern about encountering a Table with a WithQuery name before it is added to temporaryTables

I don't think we should worry too much about this as they say that WITH clause must always come before select in various docs.

• The WITH clause must always come at the beginning of the SQL statement, before any table is referenced in the main query. This placement allows the database engine to process the CTEs before executing the main query, ensuring that the defined temporary result sets are available for use throughout the rest of the statement

Oracle mysql docs also say that WITH clause must be placed at the beginning of the query or immediately preceding the SELECT statement in various contexts too.

But nonetheless it simplfies code so i changed it 👍

[mosabua]

As discussed in the sync I think we should try to get this in asap and then cut 12 - I hope you can collab on that @willmostly @ebyhr and @Chaho12

[willmostly]

lgtm!

[willmostly]

Merging for release 12 - further fixups can be done as a follow up