Remove easy-rules #540
Open
Remove easy-rules #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have not looked but removing one layer of indirection that just adds security issues and a bunch of syntax sugar seems like a good idea. |
|
Can you ask in the maintainers group about any potential suggestion or preference for a rules engine |
willmostly
force-pushed
the
will/mvel-rules
branch
2 times, most recently
from
2c476fc
to
e398d98
Compare
willmostly
commented
Oct 31, 2024
| @@ -67,7 +67,6 @@ static Stream<String> provideRoutingRuleConfigFiles() | |||
| String rulesDir = "src/test/resources/rules/"; | |||
| return Stream.of( | |||
| rulesDir + "routing_rules_atomic.yml", | |||
| rulesDir + "routing_rules_composite.yml", | |||
There was a problem hiding this comment.
This PR removes support for composite rules
willmostly
force-pushed
the
will/mvel-rules
branch
5 times, most recently
from
de8b88e
to
d2d6bfa
Compare
willmostly
changed the title
Co-Authored-By: Prakhar Sapre <[email protected]>
willmostly
force-pushed
the
will/mvel-rules
branch
from
d2d6bfa
to
3603a80
Compare
willmostly
requested review from
mosabua,
ebyhr and
oneonestar
and removed request for
mosabua and
ebyhr
|
We should get that into 13 imho .. I wont be able to review this week before Friday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove easy-rules and use mvel directly for rule evaluation This PR closes #527. The existing rule format is retained, with the exception that
easy-rulesstyleAdditional context and related issues
Trino Gateway currently leverages easy-rules to evaluate routing rules against an http request. This PR
There is ongoing discussion on which evaluation engine[s] to support. The abstract
RoutingRuleandRulesRoutingGroupSelectorclasses are intended to provide a framework to facilitate migrating to a new engine when a decision is made.The
MVELRoutingRuleandMVELFileRoutingGroupSelectorreplicate the existing easy-rules functionality, minus composite rules. Easy-rules uses mvel as the execution engine, so rule condition and action syntax does not need to be migrated. This PR drops support for composite rules, which may be a breaking change for some users.Database storage for MVEL rules will be added as a follow up.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x ) Release notes are required, with the following suggested text:
Remove easy-rules library. Breaking change: composite rules are deprecated