Implement automatic logout for WebUI #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalya
approved these changes
Nov 26, 2024
Member
vishalya
left a comment
vishalya
left a comment
There was a problem hiding this comment.
Minor comment, otherwise LGTM
webapp/src/api/base.ts
Outdated
| if (res.status === 401 || res.status === 403) { | ||
| this.authErrorHandler() | ||
| } | ||
| if (res.status !== 200) { |
Member
There was a problem hiding this comment.
Can this be changed to else if
oneonestar
force-pushed
the
star/auto_logout
branch
from
af4bd3d to
4b661e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #330.
Writing TypeScript for the first time. All I can say is this works on my local environment...
Release notes
(x) Release notes are required, with the following suggested text:
* Implement automatic logout for Web UI