Remove trailing slash in proxyTo and externalUrl in create and update backend methods #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 14, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestHaGatewayManager.java
Show resolved
Hide resolved
willmostly
reviewed
Jan 7, 2025
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
Looks good % @ebyhr's comment
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@willmostly @ebyhr can you please review. |
ebyhr
reviewed
Jan 20, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Outdated
Show resolved
Hide resolved
Member
|
Please squash commits into one. |
prakhar10
force-pushed
the
trailing-slash-issue
branch
from
edffc7d to
ea5058d
Compare
Member
Author
|
@ebyhr can you check now please? |
Member
Please remove the commit body. |
prakhar10
force-pushed
the
trailing-slash-issue
branch
from
ea5058d to
e0a6092
Compare
willmostly
approved these changes
Jan 21, 2025
ebyhr
reviewed
Jan 22, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Show resolved
Hide resolved
Member
|
Is anything here still to be done besides a merge @willmostly @ebyhr ? |
ebyhr
requested changes
Jan 29, 2025
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
(This PR isn't ready for merge)
prakhar10
force-pushed
the
trailing-slash-issue
branch
2 times, most recently
from
638785d to
b3e8469
Compare
prakhar10
force-pushed
the
trailing-slash-issue
branch
from
b3e8469 to
91ea383
Compare
Member
|
@ebyhr @willmostly .. what are we doing here? Can we get this merged or are there still open concerns? |
prakhar10
force-pushed
the
trailing-slash-issue
branch
from
bd4f881 to
5df80d0
Compare
Member
|
Ping @willmostly |
Contributor
|
@mosabua suggested release note: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove trailing slash in proxyTo and externalUrl in create and update backend methods. Fixes #564
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(X) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: