Clean webapp output folders with Maven build #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
changed the title
willmostly
approved these changes
Jan 2, 2025
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
Tested on my local build - lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the three folders are never cleaned up and depending on your setup and build with switching branches and more this can lead to the wrong impression that things are working or not work as expected.
This is a preliminary clean up to actually move the maven build parts for webapp into the webapp folder and will help for now ..
Additional context and related issues
#556
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.