Add support to handle HttpClient options for external routing group selector #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
requested changes
Jan 2, 2025
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
This explicit configuration can be avoided by injecting the airlift HttpClient. See ProxyRequestHandler as an example. This approach will allow configuration of any supported HttpClient options and be consistent with the proxy and monitor configs
Chaho12
force-pushed
the
feature/jyoo/add-request-config
branch
3 times, most recently
from
54248cc to
158c388
Compare
Member
Author
|
@willmostly @oneonestar PTAL. I added |
Chaho12
changed the title
willmostly
requested changes
Jan 9, 2025
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
Looks good, just a couple minor comments from me
gateway-ha/src/main/java/io/trino/gateway/ha/router/ExternalRoutingGroupSelector.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/ExternalRoutingGroupSelector.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/add-request-config
branch
from
158c388 to
5d3491c
Compare
ebyhr
reviewed
Jan 22, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/router/ExternalRoutingGroupSelector.java
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/ForRouter.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/RoutingGroupSelector.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/add-request-config
branch
from
5d3491c to
46f4ff0
Compare
ebyhr
reviewed
Jan 22, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ForMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/ForRouter.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/proxyserver/ForProxy.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/ExternalRoutingGroupSelector.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/add-request-config
branch
from
46f4ff0 to
23a22f6
Compare
ebyhr
reviewed
Jan 22, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/router/ExternalRoutingGroupSelector.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jyoo/add-request-config
branch
from
23a22f6 to
cca34bb
Compare
ebyhr
reviewed
Jan 22, 2025
Chaho12
force-pushed
the
feature/jyoo/add-request-config
branch
from
cca34bb to
0a27f9d
Compare
ebyhr
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds config options for users to change timeouts when making external routing requests.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: