Skip to content

Improve code quality by addressing TODO comments #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Improve code quality by addressing TODO comments #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d27ef
Throw exception when failed to parse backend URL config
Akanksha-kedia Sep 30, 2025
0909080
Remove redundant output from TestOIDC
ebyhr Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsJdbcMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ public ClusterStats monitor(ProxyBackendConfiguration backend)
properties.setProperty("SSL", String.valueOf(parsedUrl.getProtocol().equals("https")));
}
catch (MalformedURLException e) {
log.error("could not parse backend url %s ", url);
return clusterStats.build(); // TODO Invalid configuration should fail
throw new IllegalArgumentException("Invalid backend URL: " + url, e);
}

try (Connection conn = DriverManager.getConnection(jdbcUrl, properties);
Expand Down
1 change: 0 additions & 1 deletion gateway-ha/src/test/java/io/trino/gateway/ha/security/TestOIDC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ void setup()
File testConfigFile =
HaGatewayTestUtils.buildGatewayConfig("auth/oauth-test-config.yml", additionalVars);
String[] args = {testConfigFile.getAbsolutePath()};
System.out.println(ROUTER_PORT);
HaGatewayLauncher.main(args);
}

Expand Down