Fix partialCancel statement path redirection #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Oct 7, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/handler/ProxyUtils.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/handler/ProxyUtils.java
Outdated
Show resolved
Hide resolved
vishalya
reviewed
Oct 21, 2025
| || tokens[1].equals("scheduled") | ||
| || tokens[1].equals("executing") | ||
| || tokens[1].equals("partialCancel")) { | ||
| if (tokens.length >= 3 && QUERY_STATE_PATH.contains(tokens[1])) { |
Member
There was a problem hiding this comment.
I am fine with the current fix to go in as is, but we should definitely refactor this block of the code as some point.
vishalya
approved these changes
Oct 21, 2025
Member
Author
|
@ebyhr - Is this good to be merged? |
ebyhr
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial cancel url path is of form
/v1/statement/executing/partialCancel/<query_id>/...Ref - https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/java/io/trino/server/protocol/Query.java#L726
But in the code we are considering it to be of form -
/v1/statement/partialCancel/<query_id>/...without theexecutingprefix which causes failures while extracting query id. Fixed it with some minor refactoring.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(X) Release notes are required, with the following suggested text:
* bug fix: Fix partialCancel statement path redirection