Skip to content

Fix docker image build error #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Jan 7, 2026
Merged

Fix docker image build error #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
432751e
Retry JDK download in Docker image build
oneonestar Jan 7, 2026
13f3b94
Use native arch to download and extract JDK
oneonestar Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ARG TRINO_GATEWAY_BASE_IMAGE
ARG TRINO_GATEWAY_BUILD_IMAGE

FROM ${TRINO_GATEWAY_BUILD_IMAGE} AS jdk-download
FROM --platform=$BUILDPLATFORM ${TRINO_GATEWAY_BUILD_IMAGE} AS jdk-download
Copy link
Member

@Chaho12 Chaho12 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What value do you expect for $BUILDPLATFORM value?

Copy link
Member Author

@oneonestar oneonestar Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GitHub Actions runner is usually x86_64.

ARG JDK_DOWNLOAD_LINK
ARG JDK_RELEASE_NAME
ENV JAVA_HOME="/usr/lib/jvm/jdk-${JDK_RELEASE_NAME}"
Expand All @@ -26,7 +26,9 @@ RUN \
# Install JDK from the provided archive link \
echo "Downloading JDK from ${JDK_DOWNLOAD_LINK}" && \
mkdir -p "${JAVA_HOME}" && \
curl -#LfS "${JDK_DOWNLOAD_LINK}" | tar -zx --strip 1 -C "${JAVA_HOME}"
curl -#LfS --retry 8 "${JDK_DOWNLOAD_LINK}" -o /jdktarfile && \
tar -zxf /jdktarfile --strip 1 -C "${JAVA_HOME}" && \
echo "Done"

FROM ${TRINO_GATEWAY_BUILD_IMAGE} AS packages

Expand Down