-
Notifications
You must be signed in to change notification settings - Fork 129
Fix all deprecation warnings #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
…reation Co-authored-by: ebyhr <[email protected]>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@copilot Please also fix warning from |
…for container constructors Co-authored-by: ebyhr <[email protected]>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Fixed in commit b0fd305. All testcontainers deprecation warnings have been resolved by replacing string constructors with |
Description
Fixed all deprecation warnings in the trino-gateway codebase by replacing deprecated APIs with their modern equivalents:
Java Date API: Replaced deprecated
java.util.Datewithjava.time.Instantin JWT token creation. The java-jwt library 4.5.0 supportsInstantdirectly viawithExpiresAt().Testcontainers API: Replaced deprecated string constructors with
DockerImageName.parse()for all container types. In testcontainers 2.x, passing raw strings to container constructors is deprecated.Changes made:
TestTrinoRequestUser.java: RemovedDate.from()conversion, passingInstantdirectly to JWT builderDockerImageName.parse()for:GenericContainer(3 instances)FixedHostPortGenericContainer(2 instances)MySQLContainer(3 instances)PostgreSQLContainer(1 instance)TrinoContainer(9 instances)Additional context and related issues
Comprehensive scan confirmed all deprecation warnings have been addressed. The codebase now uses modern Jakarta EE APIs,
java.time, and testcontainers 2.x best practices throughout.Total deprecations fixed: 19 (1 Date API + 18 testcontainers)
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.