Fix auto formatting of throwing blocks #20316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`{ throw ...; }` lambdas read very well. However, all recent IntelliJ
versions insist on removing whitespace before `throw` and after final
`;`. This results in checkstyle violation when IDE automatic formatting
is used.
Reformat lambdas in a way that IDE automatic formatting does not violate
checkstyle rules, in order to save time when working with code.
findepi
added
the
no-release-notes
|
Also proposed airbase checker change airlift/airbase#389 |
|
CI #20323 |
wendigo
approved these changes
Jan 10, 2024
findepi
deleted the
findepi/fix-auto-formatting-of-throwing-blocks-e707e9
branch
|
Please don't do this. It makes the harder to read. I don't experience the problem you mention with IntelliJ, so we should figure out what's going on there, instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ throw ...; }lambdas read very well. However, all recent IntelliJ versions insist on removing whitespace beforethrowand after final;. This results in checkstyle violation when IDE automatic formatting is used.Reformat lambdas in a way that IDE automatic formatting does not violate checkstyle rules, in order to save time when working with code.