Skip to content

Conversation

@daha
Copy link
Member

@daha daha commented Nov 19, 2024

Fix the refresh-period configuration for
case-insensitive-name-matching.config-file.

Description

There are errors in the existing documentation for Case insensitive matching. The field
case-insensitive-name-mapping.refresh-period is not valid, it should be case-insensitive-name-matching.config-file.refresh-period.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Nov 19, 2024
@mosabua
Copy link
Member

mosabua commented Nov 19, 2024

Thanks for catching this. Did you submit a signed CLA already?

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We just got to wait for the CLA.

@daha
Copy link
Member Author

daha commented Nov 20, 2024

Thanks for catching this. Did you submit a signed CLA already?

I signed and emailed the CLA yesterday.

Fix the refresh-period configuration for
`case-insensitive-name-matching.config-file`.
@daha daha force-pushed the fix-case-insensitive-name-matching-refresh-period-config-docs branch from 43a228d to 8197c55 Compare December 5, 2024 05:51
@cla-bot cla-bot bot added the cla-signed label Dec 5, 2024
@daha
Copy link
Member Author

daha commented Dec 5, 2024

Looks good. We just got to wait for the CLA.

The CLA has been registered now.

@ebyhr ebyhr merged commit eb29dda into trinodb:master Dec 5, 2024
4 of 8 checks passed
@github-actions github-actions bot added this to the 467 milestone Dec 5, 2024
@daha daha deleted the fix-case-insensitive-name-matching-refresh-period-config-docs branch December 5, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants