Support managing views in the Faker connector #24242
Merged
+460
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Implementation looks fine but @raunaqmorarka comment on testing approach is sound IMO
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
|
I'm still working on this. |
nineinchnick
force-pushed
the
faker-views
branch
from
7550b15 to
0efe8b5
Compare
raunaqmorarka
approved these changes
Dec 25, 2024
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerViews.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
faker-views
branch
from
0efe8b5 to
7446fad
Compare
ebyhr
reviewed
Dec 26, 2024
| @@ -35,6 +36,11 @@ public String name() | |||
| return metadata.getName(); | |||
| } | |||
|
|
|||
| public Type type() | |||
|
|
||
| private final FakerFunctionProvider functionsProvider; | ||
| @GuardedBy("this") | ||
| private final Map<SchemaTableName, ConnectorViewDefinition> views = new HashMap<>(); |
There was a problem hiding this comment.
Could you add - [](sql-view-management) to faker.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: