Cleanup manifest and metadata files when any createTable fails #24279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
force-pushed
the
ks/cleanup_tx
branch
from
d5a287a to
1a27225
Compare
Previously only metadata file was cleaned up leaving Avro manifest list files present. Now both type of files are removed. Previously only some exceptions caused transaction files to be cleaned. Now all exceptions cause cleanup.
sopel39
force-pushed
the
ks/cleanup_tx
branch
from
1a27225 to
fd05503
Compare
osscm
reviewed
Nov 27, 2024
...berg/src/main/java/io/trino/plugin/iceberg/catalog/hms/AbstractMetastoreTableOperations.java
Show resolved
Hide resolved
ebyhr
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only metadata file was cleaned up leaving Avro manifest list files present. Now both type of files are removed.
Previously only some exceptions caused transaction files to be cleaned. Now all exceptions cause cleanup.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: