Reduce overhead from Slice#getInt in PlainByteArrayDecoders #24284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this is unnecessary when creating output buffer for unbounded varchars Benchmark (encoding) (positionLength) (type) Mode Cnt Before Score After Score Units BenchmarkBinaryColumnReader.read PLAIN VARIABLE_0_10 UNBOUNDED thrpt 40 105.665 ± 0.948 113.374 ± 1.893 ops/s
raunaqmorarka
requested review from
Praveen2112,
losipiuk,
sopel39 and
wendigo
losipiuk
reviewed
Dec 2, 2024
lib/trino-parquet/src/main/java/io/trino/parquet/reader/decoders/PlainByteArrayDecoders.java
Show resolved
Hide resolved
losipiuk
approved these changes
Dec 2, 2024
sopel39
reviewed
Dec 2, 2024
| * Create one big slice of data and add it to the output buffer since buffer size is known. | ||
| * Specialized for the case of strings with no truncation | ||
| */ | ||
| private static Slice createOutputBuffer(int[] offsets, int offset, int length, Slice inputSlice, int outputBufferSize) |
There was a problem hiding this comment.
so offsets have double meaning? As in it's length as out it's offset? Would be good to have that commented
| int positionLength = offsets[offset + i + 1]; | ||
| arraycopy(inputArray, inputArrayOffset + currentInputOffset + Integer.BYTES, outputBuffer, currentOutputOffset, positionLength); | ||
| offsets[offset + i + 1] = offsets[offset + i] + positionLength; | ||
| currentInputOffset += positionLength + Integer.BYTES; |
There was a problem hiding this comment.
Why add BYTES here and in arraycopy? Just add BYTES * 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using this is unnecessary when creating output buffer for unbounded varchars
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: