Fix DoubleRange resolution for NaN values #24315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devozerov
force-pushed
the
fix/nan-stats
branch
from
6d81c54 to
9fe0b89
Compare
devozerov
force-pushed
the
fix/nan-stats
branch
from
4011360 to
90ffafd
Compare
core/trino-spi/src/main/java/io/trino/spi/statistics/DoubleRange.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/statistics/DoubleRange.java
Outdated
Show resolved
Hide resolved
sopel39
approved these changes
Dec 2, 2024
devozerov
force-pushed
the
fix/nan-stats
branch
from
90ffafd to
a3f2da5
Compare
raunaqmorarka
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connector objects may contain columns that contain only
NaNvalues. When these values are passed toDoubleRangector, an exception occurs. Depending on the context, this may lead to either silent fallback to empty stats (e.g.,SHOW STATSwill give the user misleading values), or cause exceptions within an optimizer.This PR fixes the problem, normalizing ranges with NaN to empty range.
Additional context and related issues
Originally this problem was observed during careful analysis of
BaseIcebergConnectorTest.testPartitionedByDoubleWithNaNbehavior. One may think that this is an Iceberg issue, which we may fix around Iceberg'sTableStatisticsReader.makeTableStatisticsclass. However, other engines may also legitimately expose NaN as their stats, so it seems that it is better to fix it completely at the SPI level.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: