GCS filesystem cleanups #24318
Merged
GCS filesystem cleanups #24318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Nov 30, 2024
hashhar
changed the title
|
nevermind, i'll drop the 2nd commit. Needs more cleanup. GCS FS was very obviously authored by different people hence not consistent with other FSes. It's a big change for not a lot of gain. I'll send separate PR later. |
hashhar
force-pushed
the
hashhar/typo-fix
branch
from
bac80b5 to
c1c6c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple typo fix in error message
+ removing of null return from config class. Sent from Trino repo instead of fork to make sure cloud tests are run.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.