Skip to content

Add support for View Refresh operation #25906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ statement
SET PROPERTIES propertyAssignments #setMaterializedViewProperties
| DROP VIEW (IF EXISTS)? qualifiedName #dropView
| ALTER VIEW from=qualifiedName RENAME TO to=qualifiedName #renameView
| ALTER VIEW viewName=qualifiedName REFRESH #refreshView
| CALL qualifiedName '(' (callArgument (',' callArgument)*)? ')' #call
| CREATE (OR REPLACE)? functionSpecification #createFunction
| DROP FUNCTION (IF EXISTS)? functionDeclaration #dropFunction
Expand Down
134 changes: 134 additions & 0 deletions core/trino-main/src/main/java/io/trino/execution/RefreshViewTask.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.trino.execution;

import com.google.common.collect.ImmutableMap;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.inject.Inject;
import io.trino.Session;
import io.trino.execution.warnings.WarningCollector;
import io.trino.metadata.Metadata;
import io.trino.metadata.QualifiedObjectName;
import io.trino.metadata.ViewColumn;
import io.trino.metadata.ViewDefinition;
import io.trino.security.AccessControl;
import io.trino.sql.PlannerContext;
import io.trino.sql.analyzer.Analysis;
import io.trino.sql.analyzer.AnalyzerFactory;
import io.trino.sql.parser.SqlParser;
import io.trino.sql.tree.Expression;
import io.trino.sql.tree.RefreshView;
import io.trino.sql.tree.Statement;

import java.util.List;
import java.util.Optional;

import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.util.concurrent.Futures.immediateVoidFuture;
import static io.trino.metadata.MetadataUtil.createQualifiedObjectName;
import static io.trino.spi.StandardErrorCode.TABLE_NOT_FOUND;
import static io.trino.sql.analyzer.SemanticExceptions.semanticException;
import static java.util.Objects.requireNonNull;

public class RefreshViewTask
implements DataDefinitionTask<RefreshView>
{
private final PlannerContext plannerContext;
private final AccessControl accessControl;
private final SqlParser sqlParser;
private final AnalyzerFactory analyzerFactory;

@Inject
public RefreshViewTask(
PlannerContext plannerContext,
AccessControl accessControl,
SqlParser sqlParser,
AnalyzerFactory analyzerFactory)
{
this.plannerContext = requireNonNull(plannerContext, "plannerContext is null");
this.accessControl = requireNonNull(accessControl, "accessControl is null");
this.sqlParser = requireNonNull(sqlParser, "sqlParser is null");
this.analyzerFactory = requireNonNull(analyzerFactory, "analyzerFactory is null");
}

@Override
public String getName()
{
return "REFRESH VIEW";
}

@Override
public ListenableFuture<Void> execute(
RefreshView refreshView,
QueryStateMachine stateMachine,
List<Expression> parameters,
WarningCollector warningCollector)
{
Metadata metadata = plannerContext.getMetadata();
Session session = stateMachine.getSession();
QualifiedObjectName viewName = createQualifiedObjectName(session, refreshView, refreshView.getName());
if (metadata.isMaterializedView(session, viewName)) {
throw semanticException(
TABLE_NOT_FOUND,
refreshView,
"View '%s' does not exist, but a materialized view with that name exists. Did you mean ALTER MATERIALIZED VIEW %s RENAME TO ...?", viewName, viewName);
}

if (!metadata.isView(session, viewName)) {
if (metadata.getTableHandle(session, viewName).isPresent()) {
throw semanticException(
TABLE_NOT_FOUND,
refreshView,
"View '%s' does not exist, but a table with that name exists. Did you mean ALTER TABLE %s RENAME TO ...?", viewName, viewName);
}

throw semanticException(TABLE_NOT_FOUND, refreshView, "View '%s' does not exist", viewName);
}

accessControl.checkCanRefreshView(session.toSecurityContext(), viewName);

ViewDefinition viewDefinition = metadata.getView(session, viewName)
.orElseThrow(() -> semanticException(TABLE_NOT_FOUND, refreshView, "View '%s' not found", viewName));

Session viewSession = stateMachine.getSession();
if (!viewDefinition.isRunAsInvoker()) {
checkArgument(viewDefinition.getRunAsIdentity().isPresent(), "View owner detail is missing");
viewSession = viewSession.createViewSession(viewDefinition.getCatalog(), viewDefinition.getSchema(), viewDefinition.getRunAsIdentity().get(), viewDefinition.getPath());
}

Statement viewDefinitionSql = sqlParser.createStatement(viewDefinition.getOriginalSql());

Analysis analysis = analyzerFactory.createAnalyzer(viewSession, parameters, ImmutableMap.of(), stateMachine.getWarningCollector(), stateMachine.getPlanOptimizersStatsCollector())
.analyze(viewDefinitionSql);

List<ViewColumn> columns = analysis.getOutputDescriptor(viewDefinitionSql)
.getVisibleFields().stream()
.map(field -> new ViewColumn(field.getName().get(), field.getType().getTypeId(), Optional.empty()))
.collect(toImmutableList());

ViewDefinition viewDefinitionWithNewColumns = new ViewDefinition(
viewDefinition.getOriginalSql(),
viewDefinition.getCatalog(),
viewDefinition.getSchema(),
columns,
viewDefinition.getComment(),
viewDefinition.getRunAsIdentity(),
viewDefinition.getPath());

metadata.refreshView(session, viewName, viewDefinitionWithNewColumns);

return immediateVoidFuture();
}
}
5 changes: 5 additions & 0 deletions core/trino-main/src/main/java/io/trino/metadata/Metadata.java
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,11 @@ Optional<ConnectorOutputMetadata> finishRefreshMaterializedView(
*/
void renameView(Session session, QualifiedObjectName existingViewName, QualifiedObjectName newViewName);

/**
* Refreshes the view definition.
*/
void refreshView(Session session, QualifiedObjectName viewName, ViewDefinition definition);

/**
* Drops the specified view.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1609,6 +1609,15 @@ public void renameView(Session session, QualifiedObjectName source, QualifiedObj
}
}

@Override
public void refreshView(Session session, QualifiedObjectName viewName, ViewDefinition definition)
{
CatalogMetadata catalogMetadata = getCatalogMetadataForWrite(session, viewName.catalogName());
CatalogHandle catalogHandle = catalogMetadata.getCatalogHandle();
ConnectorMetadata metadata = catalogMetadata.getMetadata(session);
metadata.refreshView(session.toConnectorSession(catalogHandle), viewName.asSchemaTableName(), definition.toConnectorViewDefinition());
}

@Override
public void dropView(Session session, QualifiedObjectName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,13 @@ public interface AccessControl
*/
void checkCanRenameView(SecurityContext context, QualifiedObjectName viewName, QualifiedObjectName newViewName);

/**
* Check if identity is allowed to refresh the specified view.
*
* @throws AccessDeniedException if not allowed
*/
void checkCanRefreshView(SecurityContext context, QualifiedObjectName viewName);

/**
* Check if identity is allowed to drop the specified view.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,12 @@ public void checkCanRenameView(SecurityContext securityContext, QualifiedObjectN
catalogAuthorizationCheck(viewName.catalogName(), securityContext, (control, context) -> control.checkCanRenameView(context, viewName.asSchemaTableName(), newViewName.asSchemaTableName()));
}

@Override
public void checkCanRefreshView(SecurityContext context, QualifiedObjectName viewName)
{
//
}

@Override
public void checkCanDropView(SecurityContext securityContext, QualifiedObjectName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ public void checkCanCreateView(SecurityContext context, QualifiedObjectName view
@Override
public void checkCanRenameView(SecurityContext context, QualifiedObjectName viewName, QualifiedObjectName newViewName) {}

@Override
public void checkCanRefreshView(SecurityContext context, QualifiedObjectName viewName) {}

@Override
public void checkCanDropView(SecurityContext context, QualifiedObjectName viewName) {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
import static io.trino.spi.security.AccessDeniedException.denyKillQuery;
import static io.trino.spi.security.AccessDeniedException.denyReadSystemInformationAccess;
import static io.trino.spi.security.AccessDeniedException.denyRefreshMaterializedView;
import static io.trino.spi.security.AccessDeniedException.denyRefreshView;
import static io.trino.spi.security.AccessDeniedException.denyRenameColumn;
import static io.trino.spi.security.AccessDeniedException.denyRenameMaterializedView;
import static io.trino.spi.security.AccessDeniedException.denyRenameSchema;
Expand Down Expand Up @@ -340,6 +341,12 @@ public void checkCanRenameView(SecurityContext context, QualifiedObjectName view
denyRenameView(viewName.toString(), newViewName.toString());
}

@Override
public void checkCanRefreshView(SecurityContext context, QualifiedObjectName viewName)
{
denyRefreshView(viewName.toString());
}

@Override
public void checkCanDropView(SecurityContext context, QualifiedObjectName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ public void checkCanRenameView(SecurityContext context, QualifiedObjectName view
delegate().checkCanRenameView(context, viewName, newViewName);
}

@Override
public void checkCanRefreshView(SecurityContext context, QualifiedObjectName viewName)
{
delegate().checkCanRefreshView(context, viewName);
}

@Override
public void checkCanDropView(SecurityContext context, QualifiedObjectName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,13 @@ public void checkCanRenameView(ConnectorSecurityContext context, SchemaTableName
accessControl.checkCanRenameView(securityContext, getQualifiedObjectName(viewName), getQualifiedObjectName(viewName));
}

@Override
public void checkCanRefreshView(ConnectorSecurityContext context, SchemaTableName viewName)
{
checkArgument(context == null, "context must be null");
accessControl.checkCanRefreshView(securityContext, getQualifiedObjectName(viewName));
}

@Override
public void checkCanDropView(ConnectorSecurityContext context, SchemaTableName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import io.trino.execution.GrantTask;
import io.trino.execution.PrepareTask;
import io.trino.execution.QueryExecution.QueryExecutionFactory;
import io.trino.execution.RefreshViewTask;
import io.trino.execution.RenameColumnTask;
import io.trino.execution.RenameMaterializedViewTask;
import io.trino.execution.RenameSchemaTask;
Expand Down Expand Up @@ -93,6 +94,7 @@
import io.trino.sql.tree.Grant;
import io.trino.sql.tree.GrantRoles;
import io.trino.sql.tree.Prepare;
import io.trino.sql.tree.RefreshView;
import io.trino.sql.tree.RenameColumn;
import io.trino.sql.tree.RenameMaterializedView;
import io.trino.sql.tree.RenameSchema;
Expand Down Expand Up @@ -161,6 +163,7 @@ public void configure(Binder binder)
bindDataDefinitionTask(binder, executionBinder, Grant.class, GrantTask.class);
bindDataDefinitionTask(binder, executionBinder, GrantRoles.class, GrantRolesTask.class);
bindDataDefinitionTask(binder, executionBinder, Prepare.class, PrepareTask.class);
bindDataDefinitionTask(binder, executionBinder, RefreshView.class, RefreshViewTask.class);
bindDataDefinitionTask(binder, executionBinder, RenameColumn.class, RenameColumnTask.class);
bindDataDefinitionTask(binder, executionBinder, RenameMaterializedView.class, RenameMaterializedViewTask.class);
bindDataDefinitionTask(binder, executionBinder, RenameSchema.class, RenameSchemaTask.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@
import io.trino.sql.tree.QueryPeriod;
import io.trino.sql.tree.QuerySpecification;
import io.trino.sql.tree.RefreshMaterializedView;
import io.trino.sql.tree.RefreshView;
import io.trino.sql.tree.Relation;
import io.trino.sql.tree.RenameColumn;
import io.trino.sql.tree.RenameMaterializedView;
Expand Down Expand Up @@ -684,6 +685,12 @@ protected Scope visitInsert(Insert insert, Optional<Scope> scope)
return createAndAssignScope(insert, scope, Field.newUnqualified("rows", BIGINT));
}

@Override
protected Scope visitRefreshView(RefreshView node, Optional<Scope> scope)
{
return createAndAssignScope(node, scope);
}

@Override
protected Scope visitRefreshMaterializedView(RefreshMaterializedView refreshMaterializedView, Optional<Scope> scope)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,15 @@ public void checkCanRenameView(SecurityContext context, QualifiedObjectName view
}
}

@Override
public void checkCanRefreshView(SecurityContext context, QualifiedObjectName viewName)
{
Span span = startSpan("checkCanRefreshView");
try (var _ = scopedSpan(span)) {
delegate.checkCanRefreshView(context, viewName);
}
}

@Override
public void checkCanDropView(SecurityContext context, QualifiedObjectName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,15 @@ public void renameView(ConnectorSession session, SchemaTableName source, SchemaT
}
}

@Override
public void refreshView(ConnectorSession session, SchemaTableName viewName, ConnectorViewDefinition definition)
{
Span span = startSpan("refreshView", viewName);
try (var _ = scopedSpan(span)) {
delegate.refreshView(session, viewName, definition);
}
}

@Override
public void setViewAuthorization(ConnectorSession session, SchemaTableName viewName, TrinoPrincipal principal)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,15 @@ public void renameView(Session session, QualifiedObjectName existingViewName, Qu
}
}

@Override
public void refreshView(Session session, QualifiedObjectName viewName, ViewDefinition viewDefinition)
{
Span span = startSpan("refreshView", viewName);
try (var _ = scopedSpan(span)) {
delegate.refreshView(session, viewName, viewDefinition);
}
}

@Override
public void dropView(Session session, QualifiedObjectName viewName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import io.trino.execution.GrantRolesTask;
import io.trino.execution.GrantTask;
import io.trino.execution.PrepareTask;
import io.trino.execution.RefreshViewTask;
import io.trino.execution.RenameColumnTask;
import io.trino.execution.RenameMaterializedViewTask;
import io.trino.execution.RenameSchemaTask;
Expand Down Expand Up @@ -99,6 +100,7 @@
import io.trino.sql.tree.Prepare;
import io.trino.sql.tree.Query;
import io.trino.sql.tree.RefreshMaterializedView;
import io.trino.sql.tree.RefreshView;
import io.trino.sql.tree.RenameColumn;
import io.trino.sql.tree.RenameMaterializedView;
import io.trino.sql.tree.RenameSchema;
Expand Down Expand Up @@ -218,6 +220,7 @@ private StatementUtils() {}
.add(dataDefinitionStatement(Grant.class, GrantTask.class))
.add(dataDefinitionStatement(GrantRoles.class, GrantRolesTask.class))
.add(dataDefinitionStatement(Prepare.class, PrepareTask.class))
.add(dataDefinitionStatement(RefreshView.class, RefreshViewTask.class))
.add(dataDefinitionStatement(RenameColumn.class, RenameColumnTask.class))
.add(dataDefinitionStatement(RenameMaterializedView.class, RenameMaterializedViewTask.class))
.add(dataDefinitionStatement(RenameSchema.class, RenameSchemaTask.class))
Expand Down
Loading
Loading