Skip to content

Release grouped top n memory on output #25946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pettyjamesm
Copy link
Member

@pettyjamesm pettyjamesm commented Jun 5, 2025

Description

Releases GroupByHash and associated memory from grouped top N ranking and row number operations once output begins since the hash table is no longer necessary after that point.

Additional context and related issues

Similar to #25879

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## General
* Reduce memory consumed by grouped Top N rank and row number operations ({issue}`25946`)

@pettyjamesm pettyjamesm requested a review from dain June 5, 2025 18:59
@cla-bot cla-bot bot added the cla-signed label Jun 5, 2025
@pettyjamesm pettyjamesm marked this pull request as ready for review June 5, 2025 20:51
@wendigo wendigo requested a review from raunaqmorarka June 6, 2025 06:34
@pettyjamesm pettyjamesm merged commit 5afc98a into trinodb:master Jun 6, 2025
183 of 185 checks passed
@pettyjamesm pettyjamesm deleted the release-grouped-topn-memory-on-output branch June 6, 2025 13:57
@github-actions github-actions bot added this to the 477 milestone Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants