Expose connector-level beans in a separate domain #27623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
hudi
Member
|
Can you please add some PR desc? |
losipiuk
approved these changes
Dec 29, 2025
wendigo
force-pushed
the
serafin/fix-jmx-domains
branch
from
6ba537e to
85a4549
Compare
github-actions
bot
added
elasticsearch
Member
bump |
findepi
previously requested changes
Dec 30, 2025
plugin/trino-ai-functions/src/main/java/io/trino/plugin/ai/functions/AiConnectorFactory.java
Outdated
Show resolved
Hide resolved
...rino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchQueryRunner.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConnectorFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-opensearch/src/test/java/io/trino/plugin/opensearch/OpenSearchQueryRunner.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 30, 2025
wendigo
force-pushed
the
serafin/fix-jmx-domains
branch
2 times, most recently
from
a8212f2 to
98fad92
Compare
Contributor
Author
|
@findepi ptal |
Member
|
The build failed twice. is it a known problem? |
Contributor
Author
|
@findepi it is known |
Member
|
if there is an issue, would be nice to link here. |
Contributor
Author
|
CI hit #27716 |
Contributor
Author
|
@findepi ptal |
martint
previously requested changes
Jan 9, 2026
plugin/trino-ai-functions/src/main/java/io/trino/plugin/ai/functions/AiConnectorFactory.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fix-jmx-domains
branch
from
98fad92 to
c860ece
Compare
Contributor
Author
|
@martint ptal |
github-actions
bot
added
iceberg
wendigo
force-pushed
the
serafin/fix-jmx-domains
branch
2 times, most recently
from
fba66bf to
c5015fe
Compare
martint
reviewed
Jan 10, 2026
|
|
||
| public class ConnectorContextModule | ||
| implements Module | ||
| extends AbstractConfigurationAwareModule |
Member
There was a problem hiding this comment.
Why? This module doesn't need the facilities provided by ConfigurationAwareModule
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/ConnectorContextModule.java
Show resolved
Hide resolved
chenjian2664
approved these changes
Jan 13, 2026
Contributor
wendigo
force-pushed
the
serafin/fix-jmx-domains
branch
from
c5015fe to
07ae48e
Compare
Install ConnectorObjectNameGeneratorModule in the ConnectorContextModule to always expose catalog metrics under a separate domain qualified with catalog name.
wendigo
force-pushed
the
serafin/fix-jmx-domains
branch
from
07ae48e to
c292e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: