[AMD] Implement RepOrder for AMD MMA layouts and change kMajor notation to kMinor #5126
+47
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement RepOrder methods for MFMA and WMMA layouts. Both layouts have row major rep layout. Also,
isTranspose flag in MFMA layout does not affect RepOrder, meaning RepOrder is row major in both cases.
Also, this commit changes kMajor to kMinor notation. For a long time, kMajor is mis-used to indicate K is the fastest changing dimension. If we follow the same convention of row-major, it actually means elements on the same row are contiguous in memory.