Skip to content

Add upstream testing#82

Merged
tristanmontoya merged 8 commits intomainfrom
bg/add-upstream-test
May 9, 2025
Merged

Add upstream testing#82
tristanmontoya merged 8 commits intomainfrom
bg/add-upstream-test

Conversation

@benegee
Copy link
Collaborator

@benegee benegee commented Apr 14, 2025

Initial setup.

We need to decide which tests should be run for TrixiAtmo.jl when downstream testing is triggered in Trixi.jl' s CI.

We need the downstream part in Trixi: trixi-framework/Trixi.jl#2363

@ranocha
Copy link
Member

ranocha commented Apr 16, 2025

You should also simplify the test setup so that we just run tests once without splitting into with/without coverage as we did in Trixi.jl.

@benegee
Copy link
Collaborator Author

benegee commented Apr 16, 2025

You should also simplify the test setup so that we just run tests once without splitting into with/without coverage as we did in Trixi.jl.

So far we always run with coverage on ubuntu, and without coverage on windows and mac. We could run with coverage on all platforms, but then we would have to merge the results, right?

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (2e0e4ff) to head (3cbe01e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files          22       22           
  Lines        2189     2189           
=======================================
  Hits         1985     1985           
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ranocha
Copy link
Member

ranocha commented Apr 16, 2025

You can check what Trixi.jl does nowadays - in particular trixi-framework/Trixi.jl#2254 and trixi-framework/Trixi.jl#2261

@benegee
Copy link
Collaborator Author

benegee commented Apr 16, 2025

You can check what Trixi.jl does nowadays - in particular trixi-framework/Trixi.jl#2254 and trixi-framework/Trixi.jl#2261

I did. If we would enable coverage on all platforms we would revert #23. To make it work, I think we would need something similar to the finish step in Trixi.jl. But that would certainly be a good idea anyways.

@sloede
Copy link
Member

sloede commented Apr 16, 2025

To make it work, I think we would need something similar to the finish step in Trixi.jl. But that would certainly be a good idea anyways.

Eventually you'll probably want to split up tests like we do in Trixi.jl for reduced testing times. Then you'll need the merge step anyways. I am not sure if you really need to check coverage on non-Ubuntu platforms though - I'd probably disable it to save some time.

@benegee
Copy link
Collaborator Author

benegee commented Apr 24, 2025

I am not sure if you really need to check coverage on non-Ubuntu platforms though - I'd probably disable it to save some time.

Fine with me.
In this case we do not need a merging finish step yet, and this PR could be merged.

@tristanmontoya
Copy link
Member

@benegee Is my understanding correct that this will make it so that when trixi-framework/Trixi.jl#2363 is merged in Trixi.jl, the CI in Trixi.jl will trigger TrixiAtmo.jl to run test_trixi_consistency.jl?

If so, I am fine with merging this, so that we can move ahead with trixi-framework/Trixi.jl#2363.

@benegee
Copy link
Collaborator Author

benegee commented Apr 30, 2025

@benegee Is my understanding correct that this will make it so that when trixi-framework/Trixi.jl#2363 is merged in Trixi.jl, the CI in Trixi.jl will trigger TrixiAtmo.jl to run test_trixi_consistency.jl?

If so, I am fine with merging this, so that we can move ahead with trixi-framework/Trixi.jl#2363.

Exactly!

@benegee benegee requested a review from sloede May 2, 2025 13:48
@benegee benegee requested a review from tristanmontoya May 7, 2025 15:00
@tristanmontoya tristanmontoya merged commit 4db2ff5 into main May 9, 2025
10 checks passed
@tristanmontoya tristanmontoya deleted the bg/add-upstream-test branch May 9, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants