Skip to content

Use TrixiTest.jl #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

Use TrixiTest.jl #93

merged 1 commit into from
May 11, 2025

Conversation

JoshuaLampert
Copy link
Member

@JoshuaLampert JoshuaLampert commented May 10, 2025

This is the analogous PR to Trixi.jls trixi-framework/Trixi.jl#2395, which simplifies the custom @test_nowarn a bit to reduce maintenance. The main part has been outsourced to TrixiTest.jl.

Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (4db2ff5) to head (c4e7c17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files          22       22           
  Lines        2189     2189           
=======================================
  Hits         1985     1985           
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit 4783cd5 into main May 11, 2025
10 checks passed
@ranocha ranocha deleted the trixitest branch May 11, 2025 08:14
@benegee
Copy link
Collaborator

benegee commented May 12, 2025

Thanks a lot @JoshuaLampert!
This is big step towards cleaning up test_trixiatmo.jl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants