Skip to content

Remove surface_integral from prolong2interfaces#99

Merged
ranocha merged 1 commit intomainfrom
bg/fix-remove-surfaceintegral
Jun 24, 2025
Merged

Remove surface_integral from prolong2interfaces#99
ranocha merged 1 commit intomainfrom
bg/fix-remove-surfaceintegral

Conversation

@benegee
Copy link
Collaborator

@benegee benegee commented Jun 20, 2025

Xref: trixi-framework/Trixi.jl#2434

This was not caught in Trixi.jl's downstream tests as we currently only run one Euler elixir.

@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (8e9054c) to head (080581a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files          22       22           
  Lines        2189     2189           
=======================================
  Hits         1985     1985           
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amrueda
Copy link
Collaborator

amrueda commented Jun 23, 2025

Thanks for fixing this, @benegee!

This was not caught in Trixi.jl's downstream tests as we currently only run one Euler elixir.

I don't fully understand why this wasn't caught. Shouldn't that single elixir fail to find the function prolong2interfaces!?

@benegee
Copy link
Collaborator Author

benegee commented Jun 23, 2025

Well, I was not very precise.

prolong2interfaces originally lives in Trxi.jl, unless you override it, as done here for the solvers on manifolds. We, however, do not test these solvers in the downstream tests. I just used the warm bubble test there, based on CompressibleEulerEquations, for which we did not override rhs or pronlong2interface.

We can, and probably should, add further meaningful tests to the downstream pipeline.

@ranocha ranocha merged commit 62c4995 into main Jun 24, 2025
10 checks passed
@ranocha ranocha deleted the bg/fix-remove-surfaceintegral branch June 24, 2025 07:51
PhilBaa pushed a commit to PhilBaa/TrixiAtmo.jl that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants