Add KernelInterpolation.jl extension#73
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 96.53% 96.48% -0.06%
==========================================
Files 9 9
Lines 491 484 -7
==========================================
- Hits 474 467 -7
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 18091922947Details
💛 - Coveralls |
|
Failing docs should be fixed by #70. |
andrewwinters5000
left a comment
There was a problem hiding this comment.
Thanks for adding this capability for scattered data interpolation! It would be good if we had some scattered data in the example, but for the time being, I left a suggestion for a "manufactured" way to engineer a set of 1D scattered points.
As far as the docs go, it would be good to add a few sentences in the Overview to point to this functionality, and we can add more details or a tutorial later once we have a "real" test case.
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
andrewwinters5000
left a comment
There was a problem hiding this comment.
This looks good to me, although we could update some of the function calls in light of #75 . We should merge that PR first.
|
Can you add a bullet point and update the |
Done in 10a17b0. |
|
Ok, finally I fixed the docs such that also the docstrings of the extensions are included in the references. This is ready from my perspective. |
andrewwinters5000
left a comment
There was a problem hiding this comment.
LGTM! The only thing that is missing is you should add your name to the contributors list in AUTHORS.md
Done in 9a6fb8f. |
This PR creates a thin wrapper around my package KernelInterpolation.jl as a package extension, such that TrixiBottomTopgraphy.jl can handle arbitrary scattered data, see #45.
Some things to note:
x,y, (z) or a path to a file containing this data for easy comparison. Additionally, I implemented a general method taking any set of scattered nodes.PolyharmonicSplineKernel{1}(1)and the cubic B spline with free end conditions gives (up to ~1e-12) the same asPolyharmonicSplineKernel{1}(3).