-
Notifications
You must be signed in to change notification settings - Fork 15
Write metadata to a dedicated JSON file #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcelschurer
wants to merge
18
commits into
trixi-framework:main
Choose a base branch
from
marcelschurer:write2json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 70.74% 70.00% -0.75%
==========================================
Files 106 107 +1
Lines 6710 6750 +40
==========================================
- Hits 4747 4725 -22
- Misses 1963 2025 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LasNikas
reviewed
May 21, 2025
LasNikas
reviewed
Jun 3, 2025
/run-gpu-tests |
LasNikas
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new function
trixi2json
, which exports simulation metadata to a dedicated JSON file at the start of the simulation. Previously, metadata was stored within the VTK output files. The structure and design ofwrite_json.jl
closely follow the existing implementation inwrite_vtk.jl
for consistency.This is what the JSON files looks like for the
hydrostatic_water_comun_2d.jl
example:boundary_1_metadata.json
:fluid_1_metadata.json
:Remark: Unit tests for this function will be added in a follow-up PR. In that upcoming PR, I will implement the functionality to read
meta_data
alongside the simulation data inread_vtk.jl
.