Limit Trixi.jl compat bound to 0.8.6#52
Merged
patrickersing merged 1 commit intotrixi-framework:mainfrom Aug 16, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 61 61
Lines 2638 2638
=======================================
Hits 2619 2619
Misses 19 19 ☔ View full report in Codecov by Sentry. |
andrewwinters5000
approved these changes
Aug 16, 2024
Member
andrewwinters5000
left a comment
There was a problem hiding this comment.
LGTM. Once the Trixi PR is merged we can then readjust the compat bounds right?
Member
Author
Yes, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the upper compat bound for
Trixi.jlto the latest version 0.8.6 in order to merge trixi-framework/Trixi.jl#2038 without breaking CI.